Hi Geert,
On 22/12/11 17:18, Geert Uytterhoeven wrote:
On Thu, Dec 22, 2011 at 08:03,<gerg@xxxxxxxxxxxx> wrote:
From: Greg Ungerer<gerg@xxxxxxxxxxx>
Compiling for the m68knommu/68328 Palm/Pilot target you get:
arch/m68k/platform/68328/head-pilot.o
arch/m68k/platform/68328/head-pilot.S:37:23: fatal error: bootlogo.rh: No such file or directory
The Makefile contains rules to make the bootlogo.rh file from the C source
bootlogo.h. But it is missing a dependency that compiling head-pilot.S needs
bootlogo.rh.
Signed-off-by: Greg Ungerer<gerg@xxxxxxxxxxx>
---
arch/m68k/platform/68328/Makefile | á á3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/m68k/platform/68328/Makefile b/arch/m68k/platform/68328/Makefile
index e4dfd8f..704e36d 100644
--- a/arch/m68k/platform/68328/Makefile
+++ b/arch/m68k/platform/68328/Makefile
@@ -16,6 +16,9 @@ obj-$(CONFIG_ROM) += romvec.o
extra-y := head.o
extra-$(CONFIG_M68328) += bootlogo.rh head.o
+$(obj)/head-pilot.o: $(obj)/bootlogo.rh
+$(obj)/head-rom.o: $(obj)/bootlogo.rh
+
$(obj)/bootlogo.rh: $(src)/bootlogo.h
perl $(src)/bootlogo.pl< $(src)/bootlogo.h> $(obj)/bootlogo.rh
Nothing serious, you just made me wondering:
1. Any chance bootlogo.h can be generated from a more edit-friendly format,
cfr. drivers/video/logo/?
Looking at this I think you are right. This could be in the same way
with all the others in drivers/video/logo.
2. Why do you include the *.rh file from an assembler source file, instead of
including the *.h file from a C source file?
Although the fix involves more change to do it in C code, at least
it improves this code a little :-) So I have a different patch to fix
this that does it this way. Sending patch after this.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@xxxxxxxxxxxx
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
