On Sat, Jan 2, 2010 at 17:39, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Sat, 2 Jan 2010, Geert Uytterhoeven wrote:
On Tue, Nov 17, 2009 at 10:04, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
BTW, there are a few other minor checkpatch issues with some of the
other patches in the series, too.
I ran checkpatch on all those patches before I submitted them. I ignored
some of the complaints about whitespace where I felt that checkpatch got
it wrong (space character following tab character, IIRC).
checkpatch found lots of mistakes that I did fix, but it can't determine
the most human readable style in all cases, especially where consistency
with the surrounding code is actually more conducive to readability than
strict but sporadic conformance to simple rules would be.
It seems your editor adds spaces to lines that are continuations of
the previous statement.
I fixes them up and applied all your patches to linux-m68k.git.
The other warnings were indeed false positives or complains about
keeping consistency
with the surrounding code.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
