On Tue, Apr 28, 2009 at 07:41, Michael Schmitz
<schmitz@xxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
I found I need to have this patch in order to avoid doubly registering the
ST-DMA interrupt for IDE on Falcon.
But further it has no ill effects, as it works fine on ARAnyM? Or does
it fail on real hardware?
The interrupt is registered in stdma_init and the current user of the interrupt
is set by stdma_get_lock. Without the lock held, no interrupt should be
delivered anyway, so this patch will make it easier to debug locking problems.
Signed-off-by: Michael Schmitz <schmitz@xxxxxxxxxx>
---
drivers/ide/ide-probe.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 7f264ed..f8a86b7 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -843,6 +843,9 @@ static int init_irq (ide_hwif_t *hwif)
if (io_ports->ctl_addr)
hwif->tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
+#if defined(__mc68000__) && defined (CONFIG_BLK_DEV_FALCON_IDE)
+ if (!MACH_IS_ATARI)
+#endif
if (request_irq(hwif->irq, irq_handler, sa, hwif->name, hwif))
goto out_up;
Ugh, adding an m68k dependency in generic code is not nice...
Would it work to add a generic test for hwif->irq, and set hwif->irq to zero in
falconide.c?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
