Hi, On Sunday 15 June 2008, Geert Uytterhoeven wrote:
Hi Bart, As of June 12, drivers/ide/ide-taskfile.c fails to compile on m68k in linux-next: | drivers/ide/ide-taskfile.c:235: error: implicit declaration of function 'sg_page' | drivers/ide/ide-taskfile.c:251: error: implicit declaration of function 'sg_next' | distcc[17810] ERROR: compile drivers/ide/ide-taskfile.c on localhost failed | make[3]: *** [drivers/ide/ide-taskfile.o] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/31729/ I suspect http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=commitdiff;h=52cc802c0f45d8c15b20025e0fecf84174797307 is too blame: | ide: remove needless includes from ide-taskfile.c | -#include <linux/scatterlist.h> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ As ide-taskfile.c uses scatterlists, it should include <linux/scatterlist.h>.
Yep, obvious bug (sorry for it), fixed in IDE tree now. From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> Subject: [PATCH] ide: remove needless includes from ide-taskfile.c (take 2) v2: On Sunday 15 June 2008, Geert Uytterhoeven wrote:
As ide-taskfile.c uses scatterlists, it should include <linux/scatterlist.h>.
(v1 broke IDE build on m68k, thanks to Geert for finding the bug) Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> --- drivers/ide/ide-taskfile.c | 10 ---------- 1 file changed, 10 deletions(-) Index: b/drivers/ide/ide-taskfile.c =================================================================== --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide-taskfile.c @@ -8,28 +8,18 @@ * The big the bad and the ugly. */ -#include <linux/module.h> #include <linux/types.h> #include <linux/string.h> #include <linux/kernel.h> -#include <linux/timer.h> -#include <linux/mm.h> #include <linux/sched.h> #include <linux/interrupt.h> -#include <linux/major.h> #include <linux/errno.h> -#include <linux/genhd.h> -#include <linux/blkpg.h> #include <linux/slab.h> -#include <linux/pci.h> #include <linux/delay.h> #include <linux/hdreg.h> #include <linux/ide.h> -#include <linux/bitops.h> #include <linux/scatterlist.h> -#include <asm/byteorder.h> -#include <asm/irq.h> #include <asm/uaccess.h> #include <asm/io.h> -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
