Re: [PATCH] Workqueue updates for the Atari EtherNEC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Sun, 11 Feb 2007, Brad Boyer wrote:

On Mon, Feb 12, 2007 at 09:09:22PM +1100, Finn Thain wrote:
On Mon, 12 Feb 2007, Michael Schmitz wrote:
It also would be nice if the driver could be converted to 
module_init/module_exit before it gets merged.

Remotely related - does any m68k driver use the driver model 
framework yet? Where would we plug in the initialization of hardware 
data?

macsonic has done for a while now, and macmace got the same treatment 
in the "take 2" patch I posted a month or so back. So these became 
platform devices. It assume it would be done differently if there was 
a bus in the framework to attach them to.

I'm working on getting the macio bus finished on m68k, but I haven't had 
enough time to work on it recently. It's a bit of a pain, since it means 
moving the hardware data out of the individual drivers into something 
more generic.

From a cohesion point of view, that isn't ideal. Could that data be placed 
in __init structs and remain in the drivers?

I currently have something like the nbpmac port in ppc does, with a 
bunch of hard-coded tables matched onto the gestalt ID passed in from 
Penguin. Suggestions of a better idea would be good.

This is what mac_identify() does too. I don't see a problem with using the 
gestalt ID (?) If nothing else, it lets me use "I wish I were" to get my 
Daystar Mac II to show up as a Mac IIx (i.e. a supported model). What's 
wrong with a probe routine that just tests the macintosh_config global?

Both Penguin and the kernel test the gestalt ID, it would seem sensible to 
keep them in lockstep...

The code isn't finished yet, so I don't really have anything to share. 
I'm starting to get where I have a little more time, so I may have 
something in the next few weeks.

Doing a proper driver model framework for nubus would be a little easier
since it is possible to probe for nubus cards, unlike the onboard chips.

It's possible that might work better than what we have. If we could ensure 
that the non-nubus devices that use nubus IRQs (SONIC, Baboon, IDE...) had 
already been probed, then we might be able to prevent any unregistered 
slot IRQs, just by registering the nubus handler after nubus probing is 
done.

-f


	Brad Boyer
	flar@xxxxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux