Re: [PATCH] Workqueue updates for the Atari EtherNEC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, 8 Feb 2007, Geert Uytterhoeven wrote:

Workqueue updates for the Atari EtherNEC driver (does this make sense?)

These changes yes, but while I looked at the driver I noticed a few other 
things.

@@ -222,7 +223,7 @@ static int use_poll;
  */
 static wait_queue_head_t WaitQ;
 
-static struct work_struct tqueue;
+static struct delayed_work tqueue;
 
 #ifdef ETHERNEC_USE_POLL
 static struct {

Within ETHERNEC_USE_POLL is another work_struct, which is basically 
another delayed work event also calling basically ei_interrupt. Two worker 
doing the same thing?

It also would be nice if the driver could be converted to 
module_init/module_exit before it gets merged.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux