On Wed, 10 Jul 2024, Markus Elfring wrote: > … > > +++ b/drivers/leds/leds-lp5521.c > … > > @@ -185,9 +186,9 @@ static ssize_t lp5521_selftest(struct device *dev, > > struct lp55xx_chip *chip = led->chip; > > int ret; > > > > - mutex_lock(&chip->lock); > > + guard(mutex, &chip->lock); > > How did you come to the conclusion to try such a syntax variant out? > > Would the following statement (with additional parentheses) be more appropriate? > > guard(mutex)(&chip->lock); Yes, that's the fix. I'm more concerned with how untested patches came to being submitted. -- Lee Jones [李琼斯]
