On Tue, Jan 9, 2024, at 09:37, Lee Jones wrote:
> On Thu, 28 Dec 2023, Heiner Kallweit wrote:
>
>> If CONFIG_LEDS_CLASS = m and the caller of devm_led_classdev_register
>> is built-in, we get a compile/link error.
>> To avoid this we could add conditional compiling to the caller, but
>> exactly this overhead we wanted to avoid with adding the stubs.
>> Easiest solution is to use the existing stub also in case IS_ENABLED
>> is true, but IS_REACHABLE is false.
>>
>> Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@xxxxxxxxx/
>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
>> ---
>> include/linux/leds.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Arnd pretty much NACKed this, right?
>
> https://lore.kernel.org/r/b310230b-f20b-489a-97ed-908df193a942@xxxxxxxxxxxxxxxx
Yes, I actually wrote a replacement that does the opposite,
I just need to send that out.
Arnd
