[PATCH] leds: Change devm_led_classdev_register_ext stub logic to use IS_REACHABLE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If CONFIG_LEDS_CLASS = m and the caller of devm_led_classdev_register
is built-in, we get a compile/link error.
To avoid this we could add conditional compiling to the caller, but
exactly this overhead we wanted to avoid with adding the stubs.
Easiest solution is to use the existing stub also in case IS_ENABLED
is true, but IS_REACHABLE is false.

Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@xxxxxxxxx/
Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
---
 include/linux/leds.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/leds.h b/include/linux/leds.h
index 4754b02d3..1eecee316 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -279,7 +279,7 @@ static inline int led_classdev_register(struct device *parent,
 	return led_classdev_register_ext(parent, led_cdev, NULL);
 }
 
-#if IS_ENABLED(CONFIG_LEDS_CLASS)
+#if IS_REACHABLE(CONFIG_LEDS_CLASS)
 int devm_led_classdev_register_ext(struct device *parent,
 					  struct led_classdev *led_cdev,
 					  struct led_init_data *init_data);
-- 
2.43.0





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux