On Sat, 18 Nov 2023, Stefan Wahren wrote:
> In case leds-gpio fails to get the GPIO from the DT (e.g. the GPIO is
> already requested) the driver doesn't provide any helpful error log:
>
> leds-gpio: probe of leds failed with error -16
>
> So add a new error log in case devm_fwnode_gpiod_get() fails.
>
> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
> ---
> drivers/leds/leds-gpio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 710c319ad312..0159cedffa9e 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -172,6 +172,8 @@ static struct gpio_leds_priv *gpio_leds_create(struct device *dev)
> led.gpiod = devm_fwnode_gpiod_get(dev, child, NULL, GPIOD_ASIS,
> NULL);
> if (IS_ERR(led.gpiod)) {
> + dev_err_probe(dev, PTR_ERR(led.gpiod), "Failed to get gpio '%pfw'\n",
Nit: GPIO
> + child);
> fwnode_handle_put(child);
> return ERR_CAST(led.gpiod);
> }
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
