On Thu, 30 Nov 2023, GaryWang 汪之逸 wrote: > All, > Reply again to plain text format & line-warp and trim agree part as Jones's suggestion, > please let me know if there are still having format issue. > please kindly to check our comments with ">>" beginning. This is still incorrect. Please fix your mail client, or use a different one. > -----Original Message----- > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Sent: Tuesday, November 14, 2023 10:19 PM > To: larry.lai <larry.lai@xxxxxxxxxxxxxxx> > Cc: lee@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; pavel@xxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; linux-leds@xxxxxxxxxxxxxxx; GaryWang 汪之逸 <GaryWang@xxxxxxxxxxxx>; musa.lin@xxxxxxxxxxxxxxx; jack.chang@xxxxxxxxxxxxxxx; noah.hung@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA Why is your client putting headers in the body? > On Tue, Oct 31, 2023 at 09:51:18AM +0800, larry.lai wrote: > > The UP Squared board > > <http://www.upboard.com/> implements certain features (pin control) through an on-board FPGA. > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Signed-off-by: Gary Wang <garywang@xxxxxxxxxxxx> > > Signed-off-by: larry.lai <larry.lai@xxxxxxxxxxxxxxx> > > > > > +#include "intel/pinctrl-intel.h" > > I do not think it's correct use of the header. > >> see below No, this should look like this: > <Thing you're replying to here> [Your response here] Please fix the client to quote properly and drop the confusing ">>" stuff. > ... Make snips clearer please, either: [...] Or: [SNIP] [...] -- Lee Jones [李琼斯]
