On Tue, Oct 31, 2023 at 8:47 PM Shiji Yang <yangshiji66@xxxxxxxxxxx> wrote: > > On Tue, 31 Oct 2023 13:03:05 -0500, Rob Herring wrote: > > >On Tue, Oct 31, 2023 at 09:29:01PM +0800, Shiji Yang wrote: > >> These two types of LEDs are widely used in routers and NICs. The > >> RSSI (Received Signal Strength Indicator) LED is used to display > >> the Wi-Fi signal strength, and the Internet LED can indicate > >> whether the device can access a specific server. > >> > >> Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx> > >> --- > >> include/dt-bindings/leds/common.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > >> index 9a0d33d02..55a426e39 100644 > >> --- a/include/dt-bindings/leds/common.h > >> +++ b/include/dt-bindings/leds/common.h > >> @@ -88,11 +88,13 @@ > >> #define LED_FUNCTION_FLASH "flash" > >> #define LED_FUNCTION_HEARTBEAT "heartbeat" > >> #define LED_FUNCTION_INDICATOR "indicator" > >> +#define LED_FUNCTION_INTERNET "internet" > > > >Duplicate of 'wan'. > > > It's different from 'wan'. 'wan' usually indicates whether the WAN > port is connected to the modem (internet services may still > unavailable). But the 'internet' shows if the device can successfully > ping servers like 8.8.8.8 to detected the internet connection status. > When the router operates in AP only mode, we can even connect LAN port > to the AC/modem to connect to the internet. In this case, 'internet' > LED should still be on. On some routers, both 'internet' and 'wan' > are available and be controled separately. > > Ref: OpenWrt has a lot of devices that require the 'internet' LED： > https://git.openwrt.org/?p=openwrt%2Fopenwrt.git&a=search&h=HEAD&st=grep&s=label+%3D+.*net&sr=1 Okay, please include all this information in the commit msg. Rob
