On Tue, Oct 31, 2023 at 09:29:01PM +0800, Shiji Yang wrote: > These two types of LEDs are widely used in routers and NICs. The > RSSI (Received Signal Strength Indicator) LED is used to display > the Wi-Fi signal strength, and the Internet LED can indicate > whether the device can access a specific server. > > Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx> > --- > include/dt-bindings/leds/common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 9a0d33d02..55a426e39 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -88,11 +88,13 @@ > #define LED_FUNCTION_FLASH "flash" > #define LED_FUNCTION_HEARTBEAT "heartbeat" > #define LED_FUNCTION_INDICATOR "indicator" > +#define LED_FUNCTION_INTERNET "internet" Duplicate of 'wan'. > #define LED_FUNCTION_LAN "lan" > #define LED_FUNCTION_MAIL "mail" > #define LED_FUNCTION_MTD "mtd" > #define LED_FUNCTION_PANIC "panic" > #define LED_FUNCTION_PROGRAMMING "programming" > +#define LED_FUNCTION_RSSI "rssi" 'rx' or 'wlan'? Wouldn't you need multiple LEDs to indicate signal strength? Maybe 'signal' or something would be more generic? > #define LED_FUNCTION_RX "rx" > #define LED_FUNCTION_SD "sd" > #define LED_FUNCTION_STANDBY "standby" > -- > 2.39.2 >
