On Thu, 05 Oct 2023, Greg KH wrote: > On Thu, Oct 05, 2023 at 11:13:07AM +0100, Lee Jones wrote: > > On Thu, 05 Oct 2023, Greg KH wrote: > > > > > On Wed, Oct 04, 2023 at 10:36:09AM +0200, Florian Eckert wrote: > > > > > > > > > > > > > > I decided to move the variable definition with a separate commit > > > > > > to the top of the function, to make the build robot happy. After that > > > > > > I made my changes for v2 to the ledtrig-tty to add the feature. > > > > > > > > > > > > > Ah, lkp, then also the Closes: line as it suggests. > > > > > > > > > > > > Sorry I do not understand your statement > > > > > > > > > > The link you pasted above states: > > > > > ======= > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new > > > > > version of > > > > > the same patch/commit), kindly add following tags > > > > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > > > > | Closes: > > > > > https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@xxxxxxxxx/ > > > > > ======= > > > > > > > > > > So please follow that suggestion ;). > > > > > > > > Ok, I understand, thanks will to this on a v3 patchset. > > > > I will now wait for the comments of my changes in ledtrig-tty from the led > > > > subsystem. > > > > And then I will send a new patch set with the requested changes. > > > > > > > > Sorry for the silly question. But do I have to send this patch again for a > > > > v3? > > > > https://lore.kernel.org/linux-leds/f41dc1e1-6d34-48b2-97dd-ba67df6003c6@xxxxxxxxxx/T/#u > > > > It was already marked by you with a `Reviewed-by:` from you? > > > > Yes please. I will pick this up as a set once it's ready. > > > > > This series is long gone from my review queue, so a v3 will be needed at > > > the very least. > > > > Nothing for Greg to worry about here (unless you *want* to review). > > Yes, I want to ensure that the tty change is correct, last round I > didn't think it was... Sounds good, thanks. -- Lee Jones [李琼斯]
