On 04. 10. 23, 8:37, Florian Eckert wrote:
On 2023-10-03 07:00, Jiri Slaby wrote:
On 02. 10. 23, 16:05, Lee Jones wrote:
On Thu, 28 Sep 2023, Florian Eckert wrote:
The Intel build robot has complained about this. Hence move the commit
of the variable definition to the beginning of the function.
Please copy the robot's error message into the commit message.
For a v3 patch-set I will add the error message from build robot.
Build robot output of my v1 change:
https://lore.kernel.org/linux-leds/20230926093607.59536-1-fe@xxxxxxxxxx/T/#m777371c5de8fadc505a833139b8ae69ac7fa8dab
I decided to move the variable definition with a separate commit
to the top of the function, to make the build robot happy. After that
I made my changes for v2 to the ledtrig-tty to add the feature.
Ah, lkp, then also the Closes: line as it suggests.
Sorry I do not understand your statement
The link you pasted above states:
=======
If you fix the issue in a separate patch/commit (i.e. not just a new
version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes:
https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@xxxxxxxxx/
=======
So please follow that suggestion ;).
thanks,
--
js
suse labs
