On Thu, 22 Jun 2023, Jean-Jacques Hiblot wrote: > > > On 21/06/2023 21:33, Lee Jones wrote: > > On Fri, 16 Jun 2023, Jean-Jacques Hiblot wrote: > > > > > create mode 100644 drivers/leds/rgb/leds-group-multicolor.c > > > > Sorry to do this too you, but there are too many nits that I can't pass by. > That's alright. I'll fix them in the next (hopefully last) round > > > > > + /* Restore sysfs access when the multicolor LED is released */ > > > > > Out of interest, why are we doing this? > To prevent the user to play with the individual LEDs of the group, their > sysfs interface is disabled (read-only). The interface must be re-enabled > when the group is destroyed. Please make that very clear in the code. -- Lee Jones [李琼斯]
