On 21/06/2023 21:33, Lee Jones wrote:
On Fri, 16 Jun 2023, Jean-Jacques Hiblot wrote:
create mode 100644 drivers/leds/rgb/leds-group-multicolor.c
Sorry to do this too you, but there are too many nits that I can't pass by.
That's alright. I'll fix them in the next (hopefully last) round
+ /* Restore sysfs access when the multicolor LED is released */
Out of interest, why are we doing this?
To prevent the user to play with the individual LEDs of the group, their
sysfs interface is disabled (read-only). The interface must be
re-enabled when the group is destroyed.
+ devm_add_action_or_reset(dev, restore_sysfs_access, led_cdev);
+ }
+
+ return 0;
+}
+
+static const struct of_device_id of_led_group_multicolor_match[] = {
"leds"
+ { .compatible = "leds-group-multicolor" },
+ {}
+};
+MODULE_DEVICE_TABLE(of, of_led_group_multicolor_match);
+
+static struct platform_driver led_group_multicolor_driver = {
"leds"
+ .probe = led_mcg_probe,
+ .driver = {
+ .name = "leds_group_multicolor",
+ .of_match_table = of_led_group_multicolor_match,
+ }
+};
+module_platform_driver(led_group_multicolor_driver);
+
+MODULE_AUTHOR("Jean-Jacques Hiblot <jjhiblot@xxxxxxxxxxxxxxx>");
+MODULE_DESCRIPTION("LEDs group multicolor driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:leds-group-multicolor");
--
2.34.1
