Hi Lee, Azeem, On Tue, May 23, 2023 at 10:05:40AM +0100, Lee Jones wrote: > On Tue, 23 May 2023, Azeem Shaikh wrote: > > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > No return values were used, so direct replacement is safe. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx> > > --- > > drivers/leds/flash/leds-as3645a.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Please resubmit, taking the time to check the subject line please. I'd say also shorter description will suffice. Nowadays people understand the motivation replacing strlcpy() by strscpy() without too much elaboration. Lines may be up to 74 characters long, too, and period isn't automatically followed by a newline. The patch itself seems fine. I also prefer my @linux.intel.com address, as in MAINTAINERS for this driver. -- Kind regards, Sakari Ailus
