On Tue, 23 May 2023, Azeem Shaikh wrote: > strlcpy() reads the entire source buffer first. > This read may exceed the destination size limit. > This is both inefficient and can lead to linear read > overflows if a source string is not NUL-terminated [1]. > In an effort to remove strlcpy() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > [2] https://github.com/KSPP/linux/issues/89 > > Signed-off-by: Azeem Shaikh <azeemshaikh38@xxxxxxxxx> > --- > drivers/leds/flash/leds-as3645a.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Please resubmit, taking the time to check the subject line please. > diff --git a/drivers/leds/flash/leds-as3645a.c b/drivers/leds/flash/leds-as3645a.c > index bb2249771acb..7dc574b18f5f 100644 > --- a/drivers/leds/flash/leds-as3645a.c > +++ b/drivers/leds/flash/leds-as3645a.c > @@ -651,8 +651,8 @@ static int as3645a_v4l2_setup(struct as3645a *flash) > }, > }; > > - strlcpy(cfg.dev_name, led->dev->kobj.name, sizeof(cfg.dev_name)); > - strlcpy(cfgind.dev_name, flash->iled_cdev.dev->kobj.name, > + strscpy(cfg.dev_name, led->dev->kobj.name, sizeof(cfg.dev_name)); > + strscpy(cfgind.dev_name, flash->iled_cdev.dev->kobj.name, > sizeof(cfgind.dev_name)); > > flash->vf = v4l2_flash_init( > -- Lee Jones [李琼斯]
