Hi, On 4/14/23 14:44, Pavel Machek wrote: > On Thu 2023-04-13 17:18:04, Hans de Goede wrote: >> From: Yauhen Kharuzhy <jekhor@xxxxxxxxx> >> >> Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove >> PMIC. Charger and general-purpose leds are supported. Hardware blinking >> is implemented, breathing is not. > > leds->LEDs. > >> diff --git a/drivers/leds/leds-cht-wcove.c b/drivers/leds/leds-cht-wcove.c >> new file mode 100644 >> index 000000000000..06447804d050 >> --- /dev/null >> +++ b/drivers/leds/leds-cht-wcove.c >> @@ -0,0 +1,368 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Driver for LEDs connected to the Intel Cherry Trail Whiskey Cove PMIC >> + * >> + * Copyright 2019 Yauhen Kharuzhy <jekhor@xxxxxxxxx> >> + * Copyright 2023 Hans de Goede <hansg@xxxxxxxxxx> >> + * >> + * Based on Lenovo Yoga Book Android kernel sources >> + */ > > "sources." Should copyrights from Android be copied here? Quick follow up on this, the original file has no copyright statements, so there is nothing to copy. Also it uses a custom sysfs API, so this new LED driver was pretty much done from scratch. The only thing which comes from the Android source is hw-interface info like register addresses and what various bits in the registers mean. For v2 I've updated this comment to: * Register info comes from the Lenovo Yoga Book Android kernel sources: * YB1_source_code/kernel/cht/drivers/misc/charger_gp_led.c. Regards, Hans
