Hi Lee,
On 4/20/23 13:36, Lee Jones wrote:
> On Wed, 12 Apr 2023, Hans de Goede wrote:
>
>> Hi All,
>>
>> Here is a patch series to fix an oops about sleeping in led_trigger_blink()
>> + one other small bugfix.
>>
>> Patches 1-3 should arguably have a:
>>
>> Fixes: 0b9536c95709 ("leds: Add ability to blink via simple trigger")
>>
>> tag, but Fixes tags tend to lead to patches getting automatically added
>> to the stable series and I would prefer to see this series get some
>> significant testing time in mainline first, so I have chosen to omit
>> the tag.
>
> With subjects with the word "fix" in it, they will be hoovered up by the
> Stable auto-picker anyway.
Ok, in that case patch 3 should have:
Fixes: 0b9536c95709 ("leds: Add ability to blink via simple trigger")
Patches 1-2 are more preparation patches for this. Patch 2 does
fix another race, but I'm not sure we ever hit that.
Can you add the fixes tag while merging these, or do you
want a v2 of this series ?
Regards,
Hans
>
>> Hans de Goede (4):
>> leds: Change led_trigger_blink[_oneshot]() delay parameters to
>> pass-by-value
>> leds: Fix set_brightness_delayed() race
>> leds: Fix oops about sleeping in led_trigger_blink()
>> leds: Clear LED_INIT_DEFAULT_TRIGGER when clearing current trigger
>>
>> drivers/leds/led-core.c | 81 ++++++++++++++++++++----
>> drivers/leds/led-triggers.c | 17 ++---
>> drivers/leds/trigger/ledtrig-disk.c | 9 +--
>> drivers/leds/trigger/ledtrig-mtd.c | 8 +--
>> drivers/net/arcnet/arcnet.c | 8 +--
>> drivers/power/supply/power_supply_leds.c | 5 +-
>> drivers/usb/common/led.c | 4 +-
>> include/linux/leds.h | 43 ++++++++++---
>> net/mac80211/led.c | 2 +-
>> net/mac80211/led.h | 8 +--
>> net/netfilter/xt_LED.c | 3 +-
>> 11 files changed, 125 insertions(+), 63 deletions(-)
>>
>> --
>> 2.39.1
>>
>
