Hi, On 4/17/23 22:00, Jacek Anaszewski wrote: > Hi Hans, > > On 4/16/23 22:31, Hans de Goede wrote: >> Hi Jacek, >> >> On 4/16/23 17:17, Jacek Anaszewski wrote: >>> Hi Hans, >>> > [...] >>>> +=========================================================== >>>> +Kernel driver for Intel Cherry Trail Whiskey Cove PMIC LEDs >>>> +=========================================================== >>>> + >>>> +/sys/class/leds/<led>/hw_pattern >>>> +-------------------------------- >>>> + >>>> +Specify a hardware pattern for the Whiskey Cove PMIC LEDs. >>>> + >>>> +The only supported pattern is hardware breathing mode:: >>>> + >>>> + "0 2000 1 2000" >>> >>> Why 1? What is the peek brightness in this mode? >> >> 255, but the pattern only controls the timing. For max brightness >> the last set brightness is used and the max brightness can be changed >> while breathing by writing the brightness attribute. >> >> This is just like how blinking works in the LED subsystem, >> for both sw and hw blinking the brightness can also be changed >> while blinking. Breathing on this hw really is just a variant >> mode of blinking. > > Thanks for the explanation. So it would be nice to have it > also mentioned explicitly here. Ack, I'll add something like the above explanation to the docs for v2. Regards, Hans
