Hi!
> > > The WAN port of the 370-RD has a Marvell PHY, with one LED on
> > > the front panel. List this LED in the device tree.
> >
> > > @@ -135,6 +136,19 @@ &mdio {
> > > pinctrl-names = "default";
> > > phy0: ethernet-phy@0 {
> > > reg = <0>;
> > > + leds {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + led@0 {
> > > + reg = <0>;
> > > + label = "WAN";
> > > + color = <LED_COLOR_ID_WHITE>;
> > > + function = LED_FUNCTION_LAN;
> > > + function-enumerator = <1>;
> > > + linux,default-trigger = "netdev";
> > > + };
> >
> > /sys/class/leds/WAN is not acceptable.
>
> As i said here, that is not what it gets called:
>
> https://lore.kernel.org/netdev/aa2d0a8b-b98b-4821-9413-158be578e8e0@xxxxxxx/T/#m6c72bd355df3fcf8babc0d01dd6bf2697d069407
>
> > It can be found in /sys/class/leds/f1072004.mdio-mii:00:WAN. But when
> > we come to using it for ledtrig-netdev, the user is more likely to follow
> > /sys/class/net/eth0/phydev/leds/f1072004.mdio-mii\:00\:WAN/
>
> Is that acceptable?
>
> What are the acceptance criteria?
Acceptance criteria would be "consistent with documentation and with
other similar users". If the LED is really white, it should be
f1072004.mdio-mii\:white\:WAN, but you probably want
f1072004.mdio-mii\:white\:LAN (or :activity), as discussed elsewhere in the thread.
Documentation is in Documentation/leds/well-known-leds.txt , so you
should probably add a new section about networking, and explain naming
scheme for network activity LEDs. When next users appear, I'll point
them to the documentation.
Does that sound ok?
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
