Re: [PATCH v3 0/6] leds: Fix/Add is31fl319{0,1,3} support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 9, 2022 at 11:51 AM Vincent Knecht
<vincent.knecht@xxxxxxxxxx> wrote:
> Le mardi 05 juillet 2022 à 20:57 +0200, Andy Shevchenko a écrit :
> > On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht <vincent.knecht@xxxxxxxxxx> wrote:
> > >
> > > v3:
> > > - pick up Rob's R-b for patches 1 and 2
> > > - reinstate bindings docs license and maintainer
> > >   changes with Nikolaus agreement
> > > - took Andy's comments on patch 4 into account
> >
> > Thanks for the update. Nothing serious, but a few comments.
> >
> > Also a question here. Do you have plans to convert it to use device properties?
>
> Hi Andy, and thank you for the reviews.
> Just sent a v4:
> https://lore.kernel.org/linux-leds/20220709094642.4078222-1-vincent.knecht@xxxxxxxxxx/
>
> As for converting to device properties, it will take me some more time
> since I'm not too familiar with the concepts and how to do it exactly.

I just sent a series [1] which is based on the top of yours. You can
rebase it (it fixes a couple of subtle bugs: 1) GPIO error messaging
during error probe, and 2) mutex destruction is out of order) or
handle it together with yours. It seems you possess hardware, so I
assume you at least can test it.

> Got some hints from git history, will look into that.
> Also I'd like to add blink support...

-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux