On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht <vincent.knecht@xxxxxxxxxx> wrote: > > v3: > - pick up Rob's R-b for patches 1 and 2 > - reinstate bindings docs license and maintainer > changes with Nikolaus agreement > - took Andy's comments on patch 4 into account Thanks for the update. Nothing serious, but a few comments. Also a question here. Do you have plans to convert it to use device properties? > The is31fl3190, is31fl3191 and is31fl3193 chips (1 or 3 PWM channels) > cannot be handled the same as is31fl3196 and is31fl3199, > if only because the register map is different. > Also: > - the software shutdown bit is reversed > - and additional field needs to be set to enable all channels > - the led-max-microamp current values and setting are not the same > > Datasheets: > https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf > https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf > > This series: > > - converts dt-bindings to dtschema, adding all si-en compatibles > for convenience and consistency, and adding constraints on > supported values for eg. reg address and led-max-microamp > > - changes vars, structs and defines to not use 319X suffix > but 3190 for 319{0,1,3} and 3196 for 319{6,9} > > - adds fields in chipdef struct for chip-specific values > > - only in the last patch, adds is31fl319{0,1,3} specific values > so those chips can work. > > Tested on msm8916-alcatel-idol347, which probably has an > si-en,sn3190 or si-en,sn3191 (only one white led indicator). -- With Best Regards, Andy Shevchenko
