On Tue, Jul 5, 2022 at 8:47 PM Pali Rohár <pali@xxxxxxxxxx> wrote: > > On Tuesday 05 July 2022 20:40:26 Andy Shevchenko wrote: > > On Tue, Jul 5, 2022 at 6:11 PM Pali Rohár <pali@xxxxxxxxxx> wrote: > > > > > > This adds support for the RGB LEDs found on the front panel of the > > > Turris 1.x routers. There are 8 RGB LEDs that are controlled by > > > CZ.NIC CPLD firmware running on Lattice FPGA. > > > > > > CPLD firmware provides HW triggering mode for all LEDs except WiFi LED > > > which is automatically enabled after power on reset. LAN LEDs share HW > > > registers for RGB colors settings, so it is not possible to set different > > > colors for individual LAN LEDs. > > > > > > CZ.NIC CPLD firmware is open source and available at: > > > https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v > > > > > > This driver uses the multicolor LED framework and HW led triggers. > > > > Pardon me, but this driver seems like 3 years old by the APIs it's > > using... I have to say this, because I was surprised a lot to see some > > calls. > > I wrote it just recently according to other omnia multicolor driver. I see. I hope you will find my review useful then. -- With Best Regards, Andy Shevchenko
