Re: [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ansuel Smith <ansuelsmth@xxxxxxxxx>
Subject: Re: [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support
From: Andrew Lunn <andrew@xxxxxxx>
Date: Tue, 9 Nov 2021 22:22:57 +0100
Cc: Vivien Didelot <vivien.didelot@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Vladimir Oltean <olteanv@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Pavel Machek <pavel@xxxxxx>, John Crispin <john@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, Marek Behún <kabel@xxxxxxxxxx>
In-reply-to: <20211109022608.11109-8-ansuelsmth@gmail.com>
References: <20211109022608.11109-1-ansuelsmth@gmail.com> <20211109022608.11109-8-ansuelsmth@gmail.com>

> +static int
> +qca8k_parse_netdev(unsigned long rules, u32 *offload_trigger, u32 *mask)

This is a rather oddly named function, given that it is not actually
passed a netdev. netdev has a very well defined meaning in the network
stack, struct net_device.

       Andrew

References:
- [RFC PATCH v3 0/8] Adds support for PHY LEDs with offload triggers
  - From: Ansuel Smith
- [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support
  - From: Ansuel Smith

Prev by Date: Re: [RFC PATCH v3 6/8] leds: trigger: add hardware-phy-activity trigger
Next by Date: Re: [RFC PATCH v3 6/8] leds: trigger: add hardware-phy-activity trigger
Previous by thread: Re: [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support
Next by thread: [RFC PATCH v3 8/8] dt-bindings: net: dsa: qca8k: add LEDs definition example
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]