This is another attempt in adding support for PHY LEDs. Most of the times Switch/PHY have connected multiple LEDs that are controlled by HW based on some rules/event. Currently we lack any support for a generic way to control the HW part and normally we either never implement the feature or only add control for brightness or hw blink. This is based on Marek idea of providing some API to cled but use a different implementation that in theory should be more generilized. The current idea is: - LED driver implement 5 API (hw_control_status/start/stop/configure). They are used to put the LED in offload mode and to configure the various trigger. - We have hardware triggers that are used to expose to userspace the supported offload triggers and set the offload mode on trigger activation. - We can also have triggers that both support hardware and software mode. - The LED driver will declare each supported hardware trigger and communicate with the trigger all the supported blink modes that will be available by sysfs. - The LED driver will set how the hardware mode is activated/disabled and will set a configure function to set each supported triggers. This function provide 5 different mode enable/disable/read/supported/zero that will enable or disable the offload trigger, read the current status, check if supported or reset any active blink mode. - On hardware trigger activation, only the hardware mode is enabled but the blink modes are not configured. This means that the LED will run in hardware mode but will have the default rules/event set by the device by default. To change this the user will have to operate via userspace (or we can consider adding another binding in the dts to declare also a default trigger configuration) Each LED driver will have to declare explicit support for the offload trigger (or return not supported error code) as we pass a flag that the LED driver will elaborate and understand what is referring to (based on the current active trigger). I posted a user for this new implementation that will benefit from this and will add a big feature to it. Currently qca8k can have up to 3 LEDs connected to each PHY port and we have some device that have only one of them connected and the default configuration won't work for that. I also posted the netdev trigger expanded with the hardware support. More polish is required but this is just to understand if I'm taking the correct path with this implementation. v3: - Rework start/stop as Andrew asked. - Introduce more logic to permit a trigger to run in hardware mode. - Add additional patch with netdev hardware support. - Use test_bit API to check flag passed to hw_control_configure. - Added a new cmd to hw_control_configure to reset any active blink_mode. - Refactor all the patches to follow this new implementation. v2: - Fix spelling mistake (sorry) - Drop patch 02 "permit to declare supported offload triggers". Change the logic, now the LED driver declare support for them using the configure_offload with the cmd TRIGGER_SUPPORTED. - Rework code to follow this new implementation. - Update Documentation to better describe how this offload implementation work. Ansuel Smith (8): leds: add support for hardware driven LEDs leds: add function to configure hardware controlled LED leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode leds: trigger: netdev: rename and expose NETDEV trigger enum modes leds: trigger: netdev: add hardware control support leds: trigger: add hardware-phy-activity trigger net: dsa: qca8k: add LEDs support dt-bindings: net: dsa: qca8k: add LEDs definition example .../devicetree/bindings/net/dsa/qca8k.yaml | 20 + Documentation/leds/leds-class.rst | 53 +++ drivers/leds/Kconfig | 11 + drivers/leds/led-class.c | 27 ++ drivers/leds/led-triggers.c | 29 ++ drivers/leds/trigger/Kconfig | 28 ++ drivers/leds/trigger/Makefile | 1 + .../trigger/ledtrig-hardware-phy-activity.c | 171 +++++++ drivers/leds/trigger/ledtrig-netdev.c | 108 +++-- drivers/net/dsa/Kconfig | 9 + drivers/net/dsa/Makefile | 1 + drivers/net/dsa/qca8k-leds.c | 429 ++++++++++++++++++ drivers/net/dsa/qca8k.c | 8 +- drivers/net/dsa/qca8k.h | 65 +++ include/linux/leds.h | 115 ++++- 15 files changed, 1045 insertions(+), 30 deletions(-) create mode 100644 drivers/leds/trigger/ledtrig-hardware-phy-activity.c create mode 100644 drivers/net/dsa/qca8k-leds.c -- 2.32.0
