On Mon, 1 Nov 2021 12:59:10 +0100 Pavel Machek <pavel@xxxxxx> wrote: > Hi! > > > > Working on a driver for specific network LEDs that support HW > > triggers only I got error "Setting an LED's brightness failed" when > > switching to a different trigger. This is caused by call > > led_set_brightness(led_cdev, LED_OFF) in led_trigger_set() because > > both brigthness_set callbacks are not implemented. Let's suppress > > the error message in that case. > > Hmm... do we have such LEDs in tree? LED supporting only hardware > triggers is kind of unusual/interesting/and I'm not really sure if we > should have them in LED subsystem. Why not? I mean there actually are such LEDs and the LED subsystem is the best fit for them. The LED trigger ABI can be used to set HW control mode on these LEDs. I think it would be confusing to put such LEDs into a different subsystem. Marek
