On 01.11.2021 12:59, Pavel Machek wrote: > Hi! > > >> Working on a driver for specific network LEDs that support HW triggers >> only I got error "Setting an LED's brightness failed" when switching >> to a different trigger. This is caused by call >> led_set_brightness(led_cdev, LED_OFF) in led_trigger_set() because >> both brigthness_set callbacks are not implemented. Let's suppress >> the error message in that case. > > Hmm... do we have such LEDs in tree? LED supporting only hardware > triggers is kind of unusual/interesting/and I'm not really sure if we > should have them in LED subsystem. > This was when working on network LED support for r8169 where you can select between a number of HW triggers only. IIRC the discussion how to support such network LEDs didn't really come to a conclusion yet. Having said that at least my work hasn't been upstreamed yet. > Best regards, > Pavel > Heiner
