Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Subject: Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
From: Pavel Machek <pavel@xxxxxx>
Date: Wed, 13 Oct 2021 10:08:38 +0200
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>, johannes.berg@xxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx
In-reply-to: <20210927193424.glrddglskpohbosn@linutronix.de>
References: <20210924111501.m57cwwn7ahiyxxdd@linutronix.de> <20210927142345.GB18276@duo.ucw.cz> <87wnn2av6h.ffs@tglx> <20210927154451.GA17112@duo.ucw.cz> <20210927171802.uak3tbpqaig3mm7m@linutronix.de> <20210927190650.GA13992@duo.ucw.cz> <20210927193424.glrddglskpohbosn@linutronix.de>
User-agent: Mutt/1.5.23 (2014-03-12)

Hi!

> - The idle loop (x86 or ARM makes no difference) is always invoked with
>   disabled interrupts and so sleeping is a no no on PREEMPT_RT. So a
>   spinlock_t can not be acquired in this context.

Ok, I have reviewed code, and your patch seems like a way forward. Can
you resubmit it with fixed changelog?

Thanks,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Sebastian Andrzej Siewior

References:
- [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Sebastian Andrzej Siewior
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Pavel Machek
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Thomas Gleixner
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Pavel Machek
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Sebastian Andrzej Siewior
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Pavel Machek
- Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
  - From: Sebastian Andrzej Siewior

Prev by Date: Re: [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
Next by Date: Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
Previous by thread: Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
Next by thread: Re: [PATCH] leds: trigger: Disable CPU trigger on PREEMPT_RT
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]