Hi! > > Would you mind reading and responding to the rest of the email? > > The patch you mentioned, > https://https://lkml.kernel.org/r/.kernel.org/all/20210915181601.99a68f5718be.I1a28b342d2d52cdeeeb81ecd6020c25cbf1dbfc0@changeid/ > > would remove the lock from led_trigger_event(). > Are there any guarantees how many callbacks maybe invoked and what kind > of locks may be acquired? These kind of functions should not sleep other than that, there are no restrictions AFAICT. Other triggers are relying on that non-sleeping assumption. > Leaving kworker usage aside there are still things like spinlock_t usage > in input_leds_brightness_set(), nic78bx_brightness_set() (from a quick > grep) which have the same problems. > > > I'm not applying this. > > I hope you reconsider. It is not all LED usage, just the CPU > trigger. What makes the CPU trigger special with RT? Other triggers will be called from interesting places, too... Johanes pointed out other problems with that rwlock, and we are getting rid of the rwlock. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature
