On Thu, 9 Sep 2021 17:25:00 -0500 Ian Pilcher <arequipeno@xxxxxxxxx> wrote: > Add files: > * ledtrig-blkdev-core.c - trigger components that are always built-in > * ledtrig-blkdev.c - trigger components that can be built as a module > * ledtrig-blkdev.h - common declarations I have never seen this done this way. Add new files once you have content for them. I think this entire proposal should be done as one patch, since it atomically adds functionality. Now I have to jump between various e-mail when I want to create a mind map of what this code is doing, and it is annoying. Please resend this as: - one patch adding sysfs docs - one patch for the rest Marek