Changes from v1:
================
* Use correct address for LKML.
* Renamed the sysfs attributes used to manage and view the set of block
devices associated ("linked") with an LED.
- /sys/class/leds/<LED>/link_device to create associations
- /sys/class/leds/<LED>/unlink_device to remove associations
- /sys/class/leds/<LED>/linked_devices/ contains symlinks to all block
devices associated with the LED
- /sys/block/<DEVICE>/linked_leds (which only exists when the device is
associated with at least one LED) contains symlinks to all LEDs with
which the device is associated
link_device and unlink_device are write-only attributes, each of which
represents a single action, rather than any state. (The current state
is shown by the symbolic links in the <LED>/linked_devices/ and
<DEVICE>/linked_leds/ directories.)
* Simplified sysfs attribute store functions. link_device and
unlink_device no longer accept multiple devices at once, but this was
really just an artifact of the way that sysfs repeatedly calls the
store function when it doesn't "consume" all of its input, and it
seemed to be confusing and unpopular anyway.
* Use DEVICE_ATTR_* macros (rather than __ATTR) for the sysfs attributes.
* Removed all pr_info() "system administrator error" messages.
* Different minimum values for LED blink time (10 ms) and activity check
interval (25 ms).
Notes:
======
* Documentation for all sysfs attributes added in the first patch.
* All patches build without warnings or errors when trigger is disabled,
modular or built-in.
V1 summary:
===========
This patch series adds a new "blkdev" LED trigger for disk (or other block
device) activity LEDs.
It has the following functionality.
* Supports all types of block devices, including virtual devices
(unlike the existing disk trigger which only works with ATA devices).
* LEDs can be configured to show read activity, write activity, or both.
* Supports multiple devices and multiple LEDs in arbitrary many-to-many
configurations. For example, it is possible to configure multiple
devices with device-specific read activity LEDs and a shared write
activity LED. (See Documentation/leds/ledtrig-blkdev.rst in the first
patch.)
* Doesn't add any overhead in the I/O path. Like the netdev LED trigger,
it periodically checks the configured devices for activity and blinks
its LEDs as appropriate.
* Blink duration (per LED) and interval between activity checks (global)
are configurable.
* Requires minimal changes to the block subsystem.
- Adds 1 pointer to struct gendisk,
- Adds (inline function) call in device_add_disk() to ensure that the
pointer is initialized to NULL (as protection against any drivers
that allocate a gendisk themselves and don't use kzalloc()), and
- Adds call in del_gendisk() to remove a device from the trigger when
that device is being removed.
These changes are all in patch #4, "block: Add block device LED trigger
integrations."
* The trigger can be mostly built as a module.
When the trigger is modular, a small portion is built in to provide a
"stub" function which can be called from del_gendisk(). The stub calls
into the modular code via a function pointer when needed. The trigger
also needs the ability to find gendisk's by name, which requires access
to the un-exported block_class and disk_type symbols.
Ian Pilcher (15):
docs: Add block device (blkdev) LED trigger documentation
leds: trigger: blkdev: Add build infrastructure
leds: trigger: blkdev: Add functions needed by block changes
block: Add block device LED trigger integrations
leds: trigger: blkdev: Complete functions called by block subsys
leds: trigger: blkdev: Add function to get gendisk by name
leds: trigger: blkdev: Add constants and types
leds: trigger: blkdev: Add stub LED trigger structure
leds: trigger: blkdev: Check devices for activity and blink LEDs
leds: trigger: blkdev: Add LED trigger activate function
leds: trigger: blkdev: Enable linking block devices to LEDs
leds: trigger: blkdev: Enable unlinking block devices from LEDs
leds: trigger: blkdev: Add LED trigger deactivate function
leds: trigger: blkdev: Add remaining sysfs attributes
leds: trigger: blkdev: Add disk cleanup and init/exit functions
Documentation/ABI/testing/sysfs-block | 9 +
.../testing/sysfs-class-led-trigger-blkdev | 46 ++
Documentation/leds/index.rst | 1 +
Documentation/leds/ledtrig-blkdev.rst | 138 ++++
block/genhd.c | 4 +
drivers/leds/trigger/Kconfig | 18 +
drivers/leds/trigger/Makefile | 2 +
drivers/leds/trigger/ledtrig-blkdev-core.c | 55 ++
drivers/leds/trigger/ledtrig-blkdev.c | 686 ++++++++++++++++++
drivers/leds/trigger/ledtrig-blkdev.h | 18 +
include/linux/genhd.h | 3 +
include/linux/leds.h | 20 +
12 files changed, 1000 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-blkdev
create mode 100644 Documentation/leds/ledtrig-blkdev.rst
create mode 100644 drivers/leds/trigger/ledtrig-blkdev-core.c
create mode 100644 drivers/leds/trigger/ledtrig-blkdev.c
create mode 100644 drivers/leds/trigger/ledtrig-blkdev.h
base-commit: a3fa7a101dcff93791d1b1bdb3affcad1410c8c1
--
2.31.1
