Hi Pavel, On 18/3/2021 3:55 pm, Pavel Machek wrote: > Hi! > > > Remove unnecessary Kconfig symbol LEDS_BLINK > > Improve Kconfig help text to make it more useful. > > > > Signed-off-by: Rahul Tanwar <rtanwar@xxxxxxxxxxxxx> > > > +++ b/drivers/leds/blink/Kconfig > > @@ -1,21 +1,19 @@ > > -menuconfig LEDS_BLINK > > - bool "LED Blink support" > > - depends on LEDS_CLASS > > - help > > - This option enables blink support for the leds class. > > - If unsure, say Y. > > - > > -if LEDS_BLINK > > - > > -config LEDS_BLINK_LGM > > - tristate "LED support for Intel LGM SoC series" > > +config LEDS_LGM > > + tristate "LED support for LGM SoC series" > > depends on GPIOLIB > > depends on LEDS_CLASS > > depends on MFD_SYSCON > > depends on OF > > help > > - Parallel to serial conversion, which is also called SSO > > controller, > > - can drive external shift register for LED outputs. > > - This enables LED support for Serial Shift Output controller(SSO). > > + This option enables support for LEDs connected to GPIO lines on > > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial > > + Shift Output(SSO) controller. The driver supports hardware > > What is Lightning Mountain? The codename is not widely known. Where > can we find that hardware? Notebooks? Phones? Only some development > boards? > Lightning Mountain is generically a network processor with a primary targeted application as Gateway SoC. It has already been added as a valid Intel Atom processor variant in arch/x86/include/asm/intel-family.h as below: #define INTEL_FAM6_ATOM_AIRMONT_NP 0x75 /* Lightning Mountain */ Please see [1]. > If user is not likely to need the driver, say so. > > > + blinking with a configurable LED update/blink frequency in two > > + modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 > > KHz in > > kHz? But I guess we don't need that here. > Well noted. Will update in V2. > > * > > - * Copyright (c) 2020 Intel Corporation. > > + * Copyright (c) 2021 MaxLinear, Inc. > > */ > > > > I don't think you can do that, and I don't think you should be doing > it in the same patch. Well noted. Will revert it back now and update later in a separate patch. Thanks. > Regards, Rahul [1] https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/intel-family.h
