Remove unnecessary Kconfig symbol LEDS_BLINK Improve Kconfig help text to make it more useful. Signed-off-by: Rahul Tanwar <rtanwar@xxxxxxxxxxxxx> --- drivers/leds/Kconfig | 5 ++--- drivers/leds/Makefile | 2 +- drivers/leds/blink/Kconfig | 28 +++++++++++++--------------- drivers/leds/blink/Makefile | 2 +- drivers/leds/blink/leds-lgm-sso.c | 4 ++-- 5 files changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index b6742b4231bf..4ca8cd594518 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -928,13 +928,12 @@ config LEDS_ACER_A500 This option enables support for the Power Button LED of Acer Iconia Tab A500. +source "drivers/leds/blink/Kconfig" + comment "Flash and Torch LED drivers" source "drivers/leds/flash/Kconfig" comment "LED Triggers" source "drivers/leds/trigger/Kconfig" -comment "LED Blink" -source "drivers/leds/blink/Kconfig" - endif # NEW_LEDS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 2a698df9da57..7e604d3028c8 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -110,4 +110,4 @@ obj-$(CONFIG_LEDS_CLASS_FLASH) += flash/ obj-$(CONFIG_LEDS_TRIGGERS) += trigger/ # LED Blink -obj-$(CONFIG_LEDS_BLINK) += blink/ +obj-y += blink/ diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index 6dedc58c47b3..2de2973fbc6b 100644 --- a/drivers/leds/blink/Kconfig +++ b/drivers/leds/blink/Kconfig @@ -1,21 +1,19 @@ -menuconfig LEDS_BLINK - bool "LED Blink support" - depends on LEDS_CLASS - help - This option enables blink support for the leds class. - If unsure, say Y. - -if LEDS_BLINK - -config LEDS_BLINK_LGM - tristate "LED support for Intel LGM SoC series" +config LEDS_LGM + tristate "LED support for LGM SoC series" depends on GPIOLIB depends on LEDS_CLASS depends on MFD_SYSCON depends on OF help - Parallel to serial conversion, which is also called SSO controller, - can drive external shift register for LED outputs. - This enables LED support for Serial Shift Output controller(SSO). + This option enables support for LEDs connected to GPIO lines on + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial + Shift Output(SSO) controller. The driver supports hardware + blinking with a configurable LED update/blink frequency in two + modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 KHz in + high speed mode. The LEDs can be configured to be triggered by + SW/CPU or by hardware. Say 'Y' here if you are working on LGM + SoC based platform. + + To compile this driver as a module, choose M here: the + module will be called leds-lgm-sso. -endif # LEDS_BLINK diff --git a/drivers/leds/blink/Makefile b/drivers/leds/blink/Makefile index 2fa6c7b7b67e..fa5d04dccf13 100644 --- a/drivers/leds/blink/Makefile +++ b/drivers/leds/blink/Makefile @@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_LEDS_BLINK_LGM) += leds-lgm-sso.o +obj-$(CONFIG_LEDS_LGM) += leds-lgm-sso.o diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c index 7d5c9ca007d6..e41143a87e20 100644 --- a/drivers/leds/blink/leds-lgm-sso.c +++ b/drivers/leds/blink/leds-lgm-sso.c @@ -1,8 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Intel Lightning Mountain SoC LED Serial Shift Output Controller driver + * Lightning Mountain SoC LED Serial Shift Output Controller driver * - * Copyright (c) 2020 Intel Corporation. + * Copyright (c) 2021 MaxLinear, Inc. */ #include <linux/bitfield.h> -- 2.17.1