Hi! > > > +++ b/include/dt-bindings/leds/common.h > > > @@ -78,6 +78,7 @@ > > > #define LED_FUNCTION_INDICATOR "indicator" > > > #define LED_FUNCTION_LAN "lan" > > > #define LED_FUNCTION_MAIL "mail" > > > +#define LED_FUNCTION_MOONLIGHT "moonlight" > > > > There's "torch" function that should be used for this. I guess comment > > should be added with explanation what exactly that is and how should > > the LED be named. > > > > According to mail, 11/25 "Re: [PATCH v7 2/5] dt-bindings: leds: Add > LED_COLOR_ID_MOONLIGHT definitions", > The Moonlight LED is LED which maximum current more than torch, but > less than flash. Such as front camera fill light. > I think our channel is moonlight, not torch. > I will add this description to comment. > We can't exactly define moonlight current level, because every vendor > has their own specification. So... what is the timelimit on moonlight? But if it is used for camera illumination, I believe it should be simply called flash. Best regards, Pavel -- http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature
