On Fri, 30 Oct 2020 23:37:52 +0100 Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote: > Hi Marek, > > Bitops are guaranteed to be atomic and this was done for a reason. Hmm okay... Sooo, netdev_trig_work cannot be executed at the same time as the link/linkup/rx/tx changing stuff from netdev_trig_notify, interval_store or netdev_led_attr_store, because all these functions ensure cancelation of netdev_trig_work by calling cancel_delayed_work_sync. Doesn't this somehow prevent the need for memory barriers provided by atomic bitops? BTW Jacek what do you think about the other patches? Marek
