Re: [PATCH v3 1/5] dt-bindings: mfd: Add ENE KB930 Embedded Controller binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



09.10.2020 02:00, Sebastian Reichel пишет:
> Hi,
> 
> On Sun, Sep 06, 2020 at 10:50:59PM +0300, Dmitry Osipenko wrote:
>> Add binding document for the ENE KB930 Embedded Controller.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>> ---
>>  .../devicetree/bindings/mfd/ene-kb930.yaml    | 66 +++++++++++++++++++
>>  1 file changed, 66 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/ene-kb930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>> new file mode 100644
>> index 000000000000..635c8966ca22
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/ene-kb930.yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/ene-kb930.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ENE KB930 Embedded Controller bindings
>> +
>> +description: |
>> +  This binding describes the ENE KB930 Embedded Controller attached to an
>> +  I2C bus.
>> +
>> +maintainers:
>> +  - Dmitry Osipenko <digetx@xxxxxxxxx>
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +        - acer,a500-iconia-ec # Acer A500 Iconia tablet device
>> +      - enum:
>> +        - ene,kb930
>> +  reg:
>> +    maxItems: 1
>> +
>> +  monitored-battery: true
> 
> ^^^ this is not being used by your battery driver. Do you plan
> to use it in the future or is it a copy&paste mistake? :)

Hello, this is correct that driver doesn't use monitored-battery info,
but I was thinking that it's good to have anyways in the device-tree
because this completes hardware description + the gauge driver isn't
aware about maximal battery temperature. Hence it may become useful and
it doesn't hurt to have that additional information about battery cell.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux