The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there. Oct 6, 2020, 23:26 by kabel@xxxxxxxxxxxx: > On Mon, 5 Oct 2020 22:17:14 +0200 (CEST) > ultracoolguy@xxxxxxxxxxxx wrote: > >> Subject says it all. This rename was briefly discussed in this other patch: https://www.spinics.net/lists/linux-leds/msg16865.html (I don't know another way to link to emails, so I'll just use this archive). >> >> Feel free to suggest another name for the commit; that was just the better name I could come up with :/ . >> >> >> > > Gabriel, > > the subject of the patch should be > leds: lm3697: Rename struct into more appropiate name > ("leds: " is prefixed). Look at history > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/leds?h=v5.9-rc8 > > The commit message should mention why you are renaming the type > (something like "to be semantically more correct, since that structure > represents LED control bank as described by the datasheet"). > > Also it seems that you are using git format-patch for generating patch > files, but you are sending these patches as regular e-mail attachements. > You should instead use git send-email, as is normally required > for kernel patches (and they would also appear in patchwork > (https://patches.linaro.org/project/linux-leds/list/). Please look at > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > and https://git-send-email.io/. > > Marek >
