This: led->num_banks = count; Has to be below devm_kzalloc. Else, it's NULL. Oct 5, 2020, 17:32 by pavel@xxxxxx: > Hi! > >> Agh. I added the Signed-off-by in an earlier non-published version of the commit, but forgot to add it back. But that doesn't really excuses me. >> >> I attached the (hopefully) final version of this patch. Pavel, I'll send the struct rename separately after I submit this. >> > > Thanks, I applied it with ... some tweaks. I hope I did not break it, > and would not mind testing. > > Best regards, > Pavel > > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >