Re: [PATCH leds v3 6/9] leds: lm36274: use devres LED registering function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun 2020-09-20 23:54:36, Marek Behun wrote:
> On Sun, 20 Sep 2020 23:45:32 +0200
> Pavel Machek <pavel@xxxxxx> wrote:
> 
> > Hi!
> > 
> > > Now that the potential use-after-free issue is resolved we can use
> > > devres for LED registration in this driver.
> > > 
> > > By using devres version of LED registering function we can remove the
> > > .remove method from this driver.
> > > 
> > > Signed-off-by: Marek Behún <marek.behun@xxxxxx>
> > > Cc: Dan Murphy <dmurphy@xxxxxx>  
> > 
> > AFAICT this one is buggy, I sent explanation before. Why are you
> > resubmitting it?
> 
> The previous patch in this series (v3 5/9) should solve this issue and
> th commit message explains how.

Aha, let me see.

Will 5/9 have some side-effects, like device appearing at different
place in sysfs?

First few patches look ok, but it would be really nice someone tested
complete sereies.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux