Re: [PATCH leds + devicetree 01/13] leds: tca6507: Absorb platform data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Am 20.09.2020 um 00:15 schrieb Marek Behún <marek.behun@xxxxxx>:
> 
> The only in-tree usage of this driver is via device-tree. No on else
> includes linux/leds-tca6507.h, so absorb the definition of platdata
> structure.
> 
> Signed-off-by: Marek Behún <marek.behun@xxxxxx>
> Cc: NeilBrown <neilb@xxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>

Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>

on GTA04 (omap3-gta04.dtsi).

> ---
> drivers/leds/leds-tca6507.c  | 11 ++++++++++-
> include/linux/leds-tca6507.h | 21 ---------------------
> 2 files changed, 10 insertions(+), 22 deletions(-)
> delete mode 100644 include/linux/leds-tca6507.h
> 
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
> index a7e9fd85b6dd5..b5b5bafe2176e 100644
> --- a/drivers/leds/leds-tca6507.c
> +++ b/drivers/leds/leds-tca6507.c
> @@ -95,7 +95,6 @@
> #include <linux/i2c.h>
> #include <linux/gpio/driver.h>
> #include <linux/workqueue.h>
> -#include <linux/leds-tca6507.h>
> #include <linux/of.h>
> 
> /* LED select registers determine the source that drives LED outputs */
> @@ -108,6 +107,16 @@
> #define TCA6507_LS_BLINK0	0x6	/* Blink at Bank0 rate */
> #define TCA6507_LS_BLINK1	0x7	/* Blink at Bank1 rate */
> 
> +struct tca6507_platform_data {
> +	struct led_platform_data leds;
> +#ifdef CONFIG_GPIOLIB
> +	int gpio_base;
> +	void (*setup)(unsigned gpio_base, unsigned ngpio);
> +#endif
> +};
> +
> +#define	TCA6507_MAKE_GPIO 1
> +
> enum {
> 	BANK0,
> 	BANK1,
> diff --git a/include/linux/leds-tca6507.h b/include/linux/leds-tca6507.h
> deleted file mode 100644
> index 50d330ed11005..0000000000000
> --- a/include/linux/leds-tca6507.h
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - * TCA6507 LED chip driver.
> - *
> - * Copyright (C) 2011 Neil Brown <neil@xxxxxxxxxx>
> - */
> -
> -#ifndef __LINUX_TCA6507_H
> -#define __LINUX_TCA6507_H
> -#include <linux/leds.h>
> -
> -struct tca6507_platform_data {
> -	struct led_platform_data leds;
> -#ifdef CONFIG_GPIOLIB
> -	int gpio_base;
> -	void (*setup)(unsigned gpio_base, unsigned ngpio);
> -#endif
> -};
> -
> -#define	TCA6507_MAKE_GPIO 1
> -#endif /* __LINUX_TCA6507_H*/
> -- 
> 2.26.2
> 





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux