Re: [PATCH 1/2] leds: pca9532: correct shift computation in pca9532_getled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> Each led occupies two bits in the register, so the required shift is
> LED_NUM(id) * 2, exactly as in pca9532_setled. Furthermore, irrelevant
> higher bits need to be masked appropriately.
> 
> The function is used to implement 'default-status = "keep"', which did
> not work properly before.

Actually, dropping "keep" support if noone uses it would be best.

I can take the patch, too, but it makes sense to merge the two.

> Important Information:
> This e-mail message including its attachments contains confidential

...and send it without this trailer.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux