On Thu, 10 Sep 2020 19:34:35 +0100 Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx> wrote: > On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > > Generally the driver will default to the hardware reset blink > > pattern. There are a few PHY drivers which change this at probe, but > > not many. The silicon defaults are pretty good. > > The "right" blink pattern can be a matter of how the hardware is > wired. For example, if you have bi-colour LEDs and the PHY supports > special bi-colour mixing modes. > Have you seen such, Russell? This could be achieved via the multicolor LED framework, but I don't have a device which uses such LEDs, so I did not write support for this in the Marvell PHY driver. (I guess I could test it though, since on my device LED0 and LED1 are used, and this to can be put into bi-colour LED mode.)
