On Sat, 25 Jul 2020 17:03:42 +0200 Andrew Lunn <andrew@xxxxxxx> wrote: > Does hi-z mean off? In the implementation i did, i did not list off > and on as triggers. I instead used them for untriggered > brightness. That allowed the software triggers to work, so i had the > PHY blinking the heartbeat etc. But i had to make it optional, since a > quick survey of datasheets suggested not all PHYs support simple > on/off control. I don't actually know what hi-z means, but enabling it disabled the LED. But there is another register value for OFF... > Something beyond the scope of this patchset is implementing etHool -p > > -p --identify > Initiates adapter-specific action intended to enable an operator to > easily identify the adapter by sight. Typically this involves blink‐ > ing one or more LEDs on the specific network port. > > If we have software controlled on/off, then a software trigger seems > like i good way to do this. I'll look into this. Marek
