Hi Linus, Thanks for addressing the remarks. On 7/8/20 9:11 AM, Linus Walleij wrote:
This converts the s3c24xx LED driver to use GPIO descriptors and also modify all board files to account for these changes by registering the appropriate GPIO tables for each board. The driver was using a custom flag to indicate open drain (tristate) but this can be handled by standard descriptor machine tables. The driver was setting non-pull-up for the pin using the custom S3C24xx GPIO API, but this is a custom pin control system used by the S3C24xx and no generic GPIO function, so this has simply been pushed back into the respective board files. Cc: Ben Dooks <ben-linux@xxxxxxxxx> Cc: Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> --- ChangeLog v1->v2: - Fix two GPIO lookups in the smdk-common.c - Rename the lookup table for the backlight LED in the Mini2440 to feature the name "backlight" - Simplify the logical operation in s3c24xx_led_set() to use boolean clamping with !!value. --- arch/arm/mach-s3c24xx/common-smdk.c | 67 +++++++++++++++------- arch/arm/mach-s3c24xx/mach-mini2440.c | 63 +++++++++++++++++--- arch/arm/mach-s3c24xx/mach-n30.c | 54 +++++++++++++++-- arch/arm/mach-s3c24xx/mach-qt2410.c | 12 +++- arch/arm/mach-s3c24xx/mach-vr1000.c | 38 +++++++++++- drivers/leds/leds-s3c24xx.c | 36 +++--------- include/linux/platform_data/leds-s3c24xx.h | 6 -- 7 files changed, 199 insertions(+), 77 deletions(-)
Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> -- Best regards, Jacek Anaszewski
