On Mon, Jun 29, 2020 at 11:49 PM Jacek Anaszewski
<jacek.anaszewski@xxxxxxxxx> wrote:
> > +static struct gpiod_lookup_table mini2440_led4_gpio_table = {
> > + .dev_id = "s3c24xx_led.4",
> > + .table = {
> > + GPIO_LOOKUP("GPB", 8, NULL, GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN),
> > + { },
> > + },
> > +};
> > +
> > +static struct gpiod_lookup_table mini2440_led5_gpio_table = {
>
> Why not backlight for consistency with pdata?
>
> s/led5/led_backlight/
This platform boardfile is already using a confusion of "backlight"
and "led" for this device. The platform device is named s3c24xx_led
with .id 5 and gets named "s3c24xx_led.5". But I changed the
name of the lookup so it is a bit clearer.
> > + .dev_id = "s3c24xx_led.5",
>
> s/led.5/led_backlight/
That will not work because this lookup is tied to the platform device
name, not the LED name, which I don't change in this patch.
I fixed the rest of the comments!
Thanks,
Linus Walleij
