Hi! > > > Add support for registering per-LED device trigger. > > > > > > Names of private triggers need to be globally unique, but may clash > > > with other private triggers. This is enforced during trigger > > > > Globally unique name is going to be a problem, no? If you have two > > keyboards with automatical backlight support... > > Only globally unique in a sense that they must not clash with non > per-LED trigger names. So you can have two keyboards with 'self-working' > trigger on their LED devices in sysfs. > > This requirement only comes from the fact that this shares the > same sysfs configuration interface as regular non-private triggers. Ok. That looks sane. And if you tweak code a bit (don't compare pointers to struct led; have struct hw_trigger_group, and compare pointers to that), you should be able to fix the uglyness Marek mentioned without major changes. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature