Re: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jacek

On 5/2/20 4:51 PM, Jacek Anaszewski wrote:
Dan,

I've converted drivers/leds/leds-an30259a.c to LED mc framework
and tested it on Samsung Galaxy S3 (exysnos4412-trats2 board).
Works as expected. And now the framework usability is indeed neater.

One thing to improve: LED mc based drivers' entries in Kconfig should have this dependency:

depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR

It is required to enforce building driver as a module if
LED mc framework is configured as such.

Do you think the FLASH class needs this as well?  If so I will send this in a separate patch


With this (and DT bindings nits) addressed, for patches 1-6:

Acked-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

Ack
It's been a long journey. Thank you for your determination to drive
this work to the end.

Ack to that.

Dan





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux